HDFS-15974. RBF: Unable to display the datanode UI of the router#2915
Merged
tasanuma merged 2 commits intoapache:trunkfrom Apr 23, 2021
Merged
HDFS-15974. RBF: Unable to display the datanode UI of the router#2915tasanuma merged 2 commits intoapache:trunkfrom
tasanuma merged 2 commits intoapache:trunkfrom
Conversation
zhuxiangyi
changed the title
zhuxiangyi
changed the title
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Apr 16, 2021
| @Override | ||
| public String getEnteringMaintenanceNodes() { | ||
| return "N/A"; | ||
| return null; |
Member
There was a problem hiding this comment.
Can we add a test?
I don't think we can reproduce the JSON parsing in the browser side but let's do something closer.
Contributor
Author
There was a problem hiding this comment.
Thanks for your review @goiri , I think returning "{}" is more friendly than "null". I submitted new code and added tests.
goiri
changed the title
|
💔 -1 overall
This message was automatically generated. |
Member
|
Nice catch, @zhuxiangyi. It seems this bug became open after HDFS-15358. |
tasanuma
approved these changes
Apr 20, 2021
Member
|
@goiri Could you review it again? |
goiri
approved these changes
Apr 22, 2021
Member
|
Merged. Thanks for your contribution, @zhuxiangyi. Thanks for your reviews, @goiri. |
Contributor
Author
|
tasanuma
pushed a commit
that referenced
this pull request
Apr 23, 2021
Co-authored-by: zhuxiangyi <zhuxiangyi@360.cn> Reviewed-by: Inigo Goiri <inigoiri@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit dff95c5)
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
…che#2915) Co-authored-by: zhuxiangyi <zhuxiangyi@360.cn> Reviewed-by: Inigo Goiri <inigoiri@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDFS-15974